Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an existing person as a significant other. #35

Closed
xorgy opened this issue Jun 6, 2017 · 8 comments
Closed

Add an existing person as a significant other. #35

xorgy opened this issue Jun 6, 2017 · 8 comments

Comments

@xorgy
Copy link

xorgy commented Jun 6, 2017

I should be able to add an existing Person entry as a significant other.

@clarkd
Copy link

clarkd commented Jun 10, 2017

Seems like a no brainer! And generally just being about link (add relationship?) to another contact would be awesome.

@sid3windr
Copy link

Was going to open something similar, happy to see there are multiple requests. I'd like to indicate relationships, not only for SO (where indeed I would like to link contacts instead of just separate data), but also "Parent" (so same for children), maybe even "Cousin" etc. +1 !

@xorgy
Copy link
Author

xorgy commented Jun 18, 2017

@sid3windr "Cousin" could get a bit hairy, probably better to just show that based on the paternal, and maternal relationships of other people. Even sibling relationships get messy, possibly better to only track parental and spousal relationships, and determine the rest from that, that can fail sometimes too though.

@sid3windr
Copy link

Yes, I can agree to that.

But that would mean you'd need to add people you normally wouldn't want/need to, maybe... :-) (but that is definitely fine by me)

@mheap
Copy link

mheap commented Jun 28, 2017

If no-one's working on this, I'd love to have a go implementing it

@djaiss
Copy link
Member

djaiss commented Jul 28, 2017

I'm doing this feature at the moment. Will be ready in ~one week.

@djaiss
Copy link
Member

djaiss commented Aug 14, 2017

This is done and in production, hopefully bug free.

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants