Add newtype for Task.Par, using same encoding used in cats-effect #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
==========================================
+ Coverage 90.43% 90.47% +0.04%
==========================================
Files 366 366
Lines 9632 9632
Branches 1793 1794 +1
==========================================
+ Hits 8711 8715 +4
+ Misses 921 917 -4 |
|
Looks good 👍 |
alexandru
reviewed
Jan 18, 2018
| @@ -29,6 +30,8 @@ import scala.concurrent.Promise | |||
| * use of Task's `runAsync(callback)`. | |||
| */ | |||
| object TypeClassLawsForTaskWithCallbackSuite extends BaseLawsSuite { | |||
| implicit val ap: Applicative[Task.Par] = CatsParallelForTask.applicative | |||
There was a problem hiding this comment.
Ah, wait — so here we need a special equality defined for Task.Par, just like we have for Task. The purpose of this test suite is to test task's run-loop by using the runAsync(callback) method, instead of the normal runAsync: CancelableFuture that we are using in these tests.
alexandru
requested changes
Jan 18, 2018
alexandru
approved these changes
Jan 18, 2018
|
Looking good @Avasil, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538