fix: prepone non-ascii characters removal for Wikipedia (FortPile) #4814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very simple.
When using the Wikipedia funbox, there would be occasional consecutive spaces (like ' '). As you would have guessed, the cursor glitched in the event of one.
This (from my observations) is caused by the algorithm after fetching having to remove all non-ASCII characters (most notably '–' involved with dates) AFTER cleaning whitespaces with the regex
/\s+/g
.This process is now moved back.
I'm pretty sure this is the only source causing this issue. Otherwise, we could also clear all elements of
words
with an empty string afterconst words = sectionText.split(" ");
.Checks
_list.json
,_groups.json
and addlanguages.json
?