Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): add 8 new English quotes (LifeAdventurer) #4916

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

LifeAdventurer
Copy link
Contributor

No description provided.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 12, 2024
frontend/static/quotes/english.json Show resolved Hide resolved
frontend/static/quotes/english.json Show resolved Hide resolved
frontend/static/quotes/english.json Show resolved Hide resolved
Copy link
Contributor

@NipulM NipulM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the quotes, and they check out. Lengths match as specified. All good!

@LifeAdventurer
Copy link
Contributor Author

Thanks for reviewing my pull request.

Miodec
Miodec previously approved these changes Jan 18, 2024
@Miodec
Copy link
Member

Miodec commented Jan 18, 2024

Please resolve conflict

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 18, 2024
@Miodec
Copy link
Member

Miodec commented Jan 18, 2024

Reviewed the quotes, and they check out. Lengths match as specified. All good!

Just so you know you don't need to check lengths yourself, they are checked automatically.

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7568770486

@LifeAdventurer
Copy link
Contributor Author

Please resolve conflict

resolved

@Miodec Miodec merged commit 1ef7f10 into monkeytypegame:master Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants