-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impr(quotes): created and added two quotes in chinese_simplified.json (extoplasm) #5333
Conversation
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8825478582 |
miscounted length of first quote
Could you add a few more quotes? It would reduce the repetition |
yes was planning to, how many more do u think? |
Around 20? |
yea sure i’ll see what i can do, but gotta do it tomorrow not at computer rn thinking about adding a poem, for new lines is there a special escape character or anything? or should i type it in like one continuous line? |
You can add newlines with |
added a few more quotes, "躬自厚而薄责于人,则远怨矣。" "三人行,必有我师焉,择其善者而从之,择其不善者而改之。" "知可以战与不可以战者,胜。 " "知己知彼,百战不殆。" "横看成岭侧成峰,远近高低各不同。/n不识庐山真面目,只缘身在此山中。" "乱生于治,怯生于勇,弱生于强。" "路遥知马力,日久见人心。" "十年树木,百年树人。" "人逢喜事精神爽。" "木已成舟,生米煮成熟饭。" "冰冻三尺,非一日之寒。" "千里之行,始于足下。" "小洞不补,大洞吃苦。" "凡人不可貌相,海水不可斗量。" "严家出好儿,严师出高徒。" |
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8841806071 |
miscounted quote lengths (again) (oops)
sorry it isn't quite the 20 you asked, but i can’t rlly find many mote |
Thanks |
I think quote nr. 5 is wrong. You used |
yea i saw that, made a new pr yesterday |
…sm) (monkeytypegame#5333) * added two quotes in chinese_simplified.json * Update chinese_simplified.json miscounted length of first quote * updated quotes, added more * Update chinese_simplified.json miscounted quote lengths (again) (oops)
Description
added a quote file for chinese simplified (chinese_simplified.json)
included 2 quotes both from confucious (孔子):
"躬自厚而薄责于人,则远怨矣。“
translates to: blame not others but yourself and you will be free from resentment
"三人行,必有我师焉,择其善者而从之,择其不善者而改之。"
translates to: when three travel together, there must be one who is my teacher; learn from their successes and change their mistakes
Checks
_list.json
,_groups.json
and addlanguages.json
?Closes #