Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline Tool: exception on new/open/import project #4780

Closed
InfiniteProductions opened this issue Apr 19, 2016 · 9 comments
Closed

Pipeline Tool: exception on new/open/import project #4780

InfiniteProductions opened this issue Apr 19, 2016 · 9 comments

Comments

@InfiniteProductions
Copy link

Using dev snapshot of the pipeline tool, since almost last week, I got this exception when using open (also new or import):

System.NullReferenceException: La référence d'objet n'est pas définie à une instance d'un objet.
à Eto.WinForms.Forms.WindowsFileDialog2.<>c.b__9_0(FileDialogFilter f)
à System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()
à System.String.Join(String separator, IEnumerable1 values)
à Eto.WinForms.Forms.WindowsFileDialog2.SetFilters()
à Eto.WinForms.Forms.WindowsFileDialog`2.ShowDialog(Window parent)
à MonoGame.Tools.Pipeline.MainView.AskOpenProject(String& projectFilePath) dans M:\c#\MonoGame\MonoGame\MonoGame-develop\MonoGame\Tools\Pipeline\Eto\MainWindow.cs:ligne 67
à MonoGame.Tools.Pipeline.PipelineController.OpenProject() dans M:\c#\MonoGame\MonoGame\MonoGame-develop\MonoGame\Tools\Pipeline\Common\PipelineController.cs:ligne 221
à MonoGame.Tools.Pipeline.MainView.OnOpenProjectClick(Object sender, EventArgs e) dans M:\c#\MonoGame\MonoGame\MonoGame-develop\MonoGame\Tools\Pipeline\Windows\MainView.cs:ligne 509
à System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
à System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
à System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
à System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
à System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
à System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
à System.Windows.Forms.Control.WndProc(Message& m)
à System.Windows.Forms.ToolStrip.WndProc(Message& m)
à System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Pipeline tool from official MG 3.5.1 build works (fortunately for me).
Projects are build using protobuild for WinDx platform on win7 64b.

Using VS 2015 to debug, I got:
Exception occured in AskOpenProject (MainWindow.cs) method on line:
var result = dialog.ShowDialog(null) == Eto.Forms.DialogResult.Ok;

Comment from Alkher on the forum:

have looked into the code.A call to Init() in MainWindow.cs is missing, so dialog.CurrentFilter = _mgcbFileFilter; filters with a null value... and ShowDialogFails

@tomspilman tomspilman added this to the 3.6 Release milestone Apr 19, 2016
@tomspilman
Copy link
Member

Thanks for reporting this @InfiniteProductions !

@cra0zy ?

@harry-cpp
Copy link
Member

Yup, people on forum are right, I missed adding a Init() to the https://github.com/mono/MonoGame/blob/develop/Tools/Pipeline/Windows/MainView.cs#L39

I think I'll finish the Eto.Froms Main Window for the Pipeline Tool by tomorrow so the fix will be in that.

@tomspilman
Copy link
Member

Thanks @cra0zy !

@ed022
Copy link

ed022 commented May 8, 2016

Has this been fixed? Where can I obtain the updated version?

@harry-cpp
Copy link
Member

harry-cpp commented May 8, 2016

#4786 fixes it. It's not merged yet.

@ed022
Copy link

ed022 commented May 8, 2016

Pardon my ignorance; I'm new to the Mono and GitHub scenes. Is there an executable update, or do I have to manually build from this code repository?

@harry-cpp
Copy link
Member

If you want to test out the PR above, you can grab the installer from the build bot: http://teamcity.monogame.net/viewLog.html?buildId=12315&buildTypeId=MonoGame_PackagingWindows&tab=artifacts&guest=1

@ed022
Copy link

ed022 commented May 8, 2016

Cool, thank you very much! =)

@Jjagg
Copy link
Contributor

Jjagg commented Jun 11, 2016

With #4786 merged, this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants