Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 8 Storage fixes #1074

Merged
merged 1 commit into from Feb 18, 2013
Merged

Conversation

WaaghMan
Copy link
Contributor

  • Fixed BeginShowSelector / EndShowSelector not working.
  • Fixed BeginOpenContainer / EndOpenContainer not working.
    ** Static variables added as a workaround for not being able to cast IAsyncResult to AsyncResult.
  • Fixed StorageContainer methods throwing exceptions because there was no wait on the async methods.
  • Fixed base path for StorageContainer
  • Added a try/catch to StorageContainer.FileExists and StorageContainer.DirectoryExists
  • Fixed OpenFile opening a Stream on the end of the file when the file existed.

* Fixed BeginShowSelector / EndShowSelector not working.
* Fixed BeginOpenContainer / EndOpenContainer not working.
** Static variables added as a workaround for not being able to cast IAsyncResult to AsyncResult.

* Fixed StorageContainer methods throwing exceptions because there was no wait on the async methods.
* Fixed base path for StorageContainer
* Added a try/catch to StorageContainer.FileExists and StorageContainer.DirectoryExists
* Fixed OpenFile opening a Stream on the end of the file when the file existed.
@tomspilman
Copy link
Member

We need someone that uses StorageContainer to give this a try.

@demonixis
Copy link
Contributor

Hi,

I've tested it and it's work for save a file but when i'm try to loading datas i've this error

Exception de HRESULT : 0x80070005 (E_ACCESSDENIED

The problem seem to be in StorageContainer.cs line 515

@KonajuGames
Copy link
Contributor

E_ACCESSDENIED usually happens when a stream has not been closed properly
when it was last used.

@mgbot
Copy link
Member

mgbot commented Feb 6, 2013

Can one of the admins verify this patch?

@dellis1972
Copy link
Contributor

@mgbot test

@tomspilman
Copy link
Member

So another complication here. We just applied the branch migration plans:

https://github.com/mono/MonoGame/wiki/Branch-Migration-Strategy

So the develop3d branch will stop being updated and eventually deleted. So that leaves you with a choice here:

  1. Close this PR and resubmit to the develop branch.
  2. Let me merge it with develop3d, but there will be a delay of a few days before it is moved into develop.

Totally your call.

@WaaghMan
Copy link
Contributor Author

Well, I'd go with 2 since it means less work for me :). Anyway the code should be fine, we're already using it on a game published on the Windows Store.

tomspilman added a commit that referenced this pull request Feb 18, 2013
@tomspilman tomspilman merged commit 6691dd7 into MonoGame:develop3d Feb 18, 2013
renaudbedard pushed a commit to renaudbedard/MonoGame that referenced this pull request Feb 22, 2013
alxwest pushed a commit to alxwest/MonoGame that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants