Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WindowsPhone81 platform to Content Pipeline #3312

Closed
wants to merge 1 commit into from

Conversation

Nezz
Copy link
Member

@Nezz Nezz commented Dec 24, 2014

Should it have a different identifier?

@tomspilman
Copy link
Member

I didn't add it because it generates the same content so far for WP8 and 8.1.

I'd rather not merge this until we actually need it.

@Nezz
Copy link
Member Author

Nezz commented Dec 24, 2014

The same is true for a bunch of other platforms, like Windows 8. I had to add it because I wanted to avoid conflicts.

@tomspilman
Copy link
Member

The same is true for a bunch of other platforms, like Windows 8.

That is true, but I can understand having one per-platform... it is called TargetPlatform after all.

I just get hesitant when we start adding platform version numbers in there. Especially when a new one isn't yet needed.

I had to add it because I wanted to avoid conflicts.

Avoid conflicts with what?

@Nezz
Copy link
Member Author

Nezz commented Dec 27, 2014

You might need to seperate the two platforms because WP8.0 doesn't support 1080p, while WP8.1 does.

@tomspilman
Copy link
Member

You might need to seperate the two platforms because WP8.0 doesn't support 1080p, while WP8.1 does.

Yeah... maybe. @KonajuGames do you have an opinion on this?

@KonajuGames
Copy link
Contributor

Given the 1080p example, you still wouldn't need a separate platform identifier because you would be checking the resolution of the device before loading any 1080p-specific content. Since WP8.0 won't report 1080p, you just simply won't load that content.

If there was a need for different processing for the same data, then it would be reasonable to have the extra identifier.

@Nezz
Copy link
Member Author

Nezz commented Jan 15, 2015

I don't want to include it in my XAP/APPX either.

@tomspilman
Copy link
Member

I don't want to include it in my XAP/APPX either.

I think this is where having more than one "configuration" needs to come into play. The configuration is like "Debug" or "Release" ... in old XNA no one really used them. However it has been our plan to support them for things like demo builds, adding dlc content, HD content, etc. The idea was to be able to change properties or include content under only one particular config.

Like ideally you can tell it to build for WindowsPhone8, but pass a configuration identifier like "HDContent" that makes it include the additional 1080p content.

@Nezz Nezz closed this Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants