New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector4 docs #3857
Vector4 docs #3857
Conversation
This PR brought up something strange with how |
@nkast Thanks, I fixed it. please said me if I incorrect. |
Actually I was talking about inlining Length(), LengthSquared() and Normalize(ref Vector4 value, out Vector4 result). My plan was to submit the changes after this PR was merged. |
@nkast Ok. I left these changes for you. |
@tomspilman @KonajuGames So.. what about merging ? |
@tomspilman Please react |
@@ -392,9 +392,9 @@ public static void Distance(ref Vector3 value1, ref Vector3 value2, out float re | |||
/// <returns>The squared distance between two vectors.</returns> | |||
public static float DistanceSquared(Vector3 value1, Vector3 value2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a unit test for this as there isn't one and we need to be sure this didn't break anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if @nkast plans to re-write this then I can merge as is. He will just need to write the tests for it then.
So I made these tests.. it is ok ? |
Ok... merging! |
Fully documented Vector4 struct,
+few fixes to other things
+tests
+added missing Transform overloads