[Gtk Pipeline] Fixed null crash when viewing project properties #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @cra0zy . Merging. |
KonajuGames
added a commit
that referenced
this pull request
May 19, 2015
[Gtk Pipeline] Fixed null crash when viewing project properties
|
I just noticed I said null crash instead of duplicate keys crash in commit text... my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework.Content.Pipeline/TargetPlatform.cs#L100 when WindowsGL or Linux were read they were automatically repinted to DesktopGL, and then with the old Dictionary creating code it was trying to add multiple DesktopGL keys which in turn caused a crash. This fixes it.
Also I can't check if WindowsGL and Linux are obsolete anymore because of the same reason.