This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
[corlib] Import System.IO.Stream/BufferedStream from CoreFX #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marek-safar
suggested changes
Sep 29, 2018
| @@ -647,8 +647,11 @@ void ITaskCompletionAction.Invoke(Task completingTask) | |||
|
|
|||
| var invokeAsyncCallback = s_invokeAsyncCallback; | |||
| if (invokeAsyncCallback == null) s_invokeAsyncCallback = invokeAsyncCallback = InvokeAsyncCallback; // benign race condition | |||
|
|
|||
| #if MONO // Mono uses ExecutionContext from referencesource | |||
There was a problem hiding this comment.
Could we make this change on our side (add a new overload)
alexischr
force-pushed
the
corefx-System.IO.Stream
branch
2 times, most recently
from
8a5f635
to
7641bb7
Compare
alexischr
force-pushed
the
corefx-System.IO.Stream
branch
3 times, most recently
from
6503a67
to
d87dd62
Compare
alexischr
force-pushed
the
corefx-System.IO.Stream
branch
from
d87dd62
to
1117c4a
Compare
marek-safar
reviewed
Oct 25, 2018
| @@ -387,9 +397,27 @@ async ValueTask<int> FinishReadAsync(Task<int> readTask, byte[] localBuffer, Mem | |||
| ArrayPool<byte>.Shared.Return(localBuffer); | |||
| } | |||
| } | |||
| #else | |||
| return new ValueTask<int> (FinishReadAsync(ReadAsync(sharedBuffer, 0, buffer.Length, cancellationToken), sharedBuffer, buffer)); | |||
There was a problem hiding this comment.
This should be just
Suggested change
| return new ValueTask<int> (FinishReadAsync(ReadAsync(sharedBuffer, 0, buffer.Length, cancellationToken), sharedBuffer, buffer)); | |
| return FinishReadAsync(ReadAsync(sharedBuffer, 0, buffer.Length, cancellationToken), sharedBuffer, buffer); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with mono/mono#10880