Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[corlib] Import System.IO.Stream/BufferedStream from CoreFX #10880

Merged
merged 3 commits into from
Nov 7, 2018
Merged

[corlib] Import System.IO.Stream/BufferedStream from CoreFX #10880

merged 3 commits into from
Nov 7, 2018

Conversation

alexischr
Copy link
Contributor

@alexischr alexischr commented Sep 28, 2018 •
edited

Merge with mono/corert#26

Part of #7246

Adds ~300 tests

@alexischr alexischr mentioned this pull request Sep 28, 2018
Merged
@alexischr
Copy link
Contributor Author

@monojenkins build failed

1 similar comment
@alexischr
Copy link
Contributor Author

@monojenkins build failed

marek-safar
marek-safar previously requested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@marek-safar marek-safar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the imported types

@alexischr alexischr force-pushed the corefx-System.IO.Stream branch 2 times, most recently from 03dbfc7 to 3835eb6 Compare October 23, 2018 22:55
@alexischr alexischr mentioned this pull request Oct 23, 2018
Merged
@alexischr alexischr force-pushed the corefx-System.IO.Stream branch 5 times, most recently from 7e88ced to 45c5e5b Compare October 24, 2018 15:55
@alexischr
Copy link
Contributor Author

@monojenkins build

1 similar comment
@alexischr
Copy link
Contributor Author

@monojenkins build

@alexischr
Copy link
Contributor Author

@monojenkins commit apidiff and csproj

@akoeplinger
Copy link
Member

akoeplinger commented Oct 26, 2018 •
edited

@alexischr you should merge the corefx changes first and then bump the submodule ref here to avoid problems like we had recently where the submodule was pointing to an older commit, and only then do the apidiff commit (since as soon as you do that no other apidiff changes can go in on other PRs because it's the same submodule)

@marek-safar
Copy link
Member

@alexischr could you resolve the conflict

@alexischr
Copy link
Contributor Author

@monojenkins commit apidiff and csproj

1 similar comment
@alexischr
Copy link
Contributor Author

@monojenkins commit apidiff and csproj

monojenkins added a commit to mono/api-snapshot that referenced this pull request Nov 7, 2018
@monojenkins
Apply changes from mono/mono#10880 to API snapshot
bbb7c92
@alexischr alexischr merged commit 46a2830 into mono:master Nov 7, 2018
akoeplinger pushed a commit to mono/corert that referenced this pull request Nov 7, 2018
@alexischr @akoeplinger
[corlib] Import System.IO.Stream/BufferedStream from CoreFX (#26)
0e5f123 
Merge with mono/mono#10880
@mfilippov
Copy link
Contributor

@akoeplinger @alexischr Could you backport it into 2018-10. We have a lot of hacks to avoid NotImplementedException from Stream.cs and we should add new hacks to migrate to 2018-10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@luhenry luhenry Awaiting requested review from luhenry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexischr @akoeplinger @marek-safar @mfilippov @monojenkins