[Debugger] Record time it took between steps. #12217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest-arm64/8921/testReport/junit/(root)/DebuggerTests/StackTraceInNative/ for example, we have no idea why the underlying process has exited. To figure it out, we need to go to https://jenkins.mono-project.com/job/test-mono-pull-request-arm64/8921/parsed_console/log_content.html#WARNING1 and scroll back up to where the test was executed to find out the debuggee process crashed with an assertion. This was fixed by redirecting the StandardOutput and StandardError of the debuggee process in the Mono.Debugger.Soft test suite.
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
|
@monojenkins commit apidiff |
|
@monojenkins build failed |
I implemented a new message to avoid breaking the protocol. I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent. Fixes mono#8460
|
@monojenkins commit apidiff |
alexischr
approved these changes
Dec 31, 2018
alexischr
reviewed
Dec 31, 2018
| @@ -30,11 +30,20 @@ public class ThreadMirror : ObjectMirror | |||
| return frames; | |||
| } | |||
|
|
|||
| public long ElapsedTime () { | |||
| long elapsedTime = GetElapsedTime (); | |||
There was a problem hiding this comment.
How come this is split into also an internal method (ie. why not return vm.conn.Thread_GetElapsedTime (id))?
There was a problem hiding this comment.
I don't have a good reason I was following the other implementations, but I really think that this is an unnecessary overhead. Should I change this and do a new PR?
monojenkins
added a commit
to mono/api-snapshot
that referenced
this pull request
Dec 31, 2018
|
@vargaz @thaystg @alexischr @marek-safar heads-up, this was merged without bumping the protocol version, introducing a potential binary protocol breakage. The version of the server and client should be bumped. |
|
@thaystg could you address above ^ |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a new message to avoid breaking the protocol.
I used the MonoStopwatch to count the time between the steps, it was already used in the debugger-agent.
There is a new unit test to check this feature.
Fixes #8460