Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get correct AAC ADTS bitrate #51

Closed
Magentaize opened this issue Feb 4, 2017 · 5 comments
Closed

Cannot get correct AAC ADTS bitrate #51

Magentaize opened this issue Feb 4, 2017 · 5 comments

Comments

@Magentaize
Copy link

The encoder is qaac 2.55, CoreAudioToolbox 7.10.6.0, AAC-LC Encoder, TVBR q127, Quality 96

@Magentaize
Copy link
Author

The correct bitrate should be computed by sizeof("mdat") * 8 / Duration instead of read from the header.

@decriptor
Copy link
Collaborator

@PeoLeser any chance I could talk you into writing a unit test for this and documenting the unit test? Or even better the unit test and a fix? :)

@Magentaize
Copy link
Author

Magentaize commented Feb 5, 2017

@decriptor I have uploaded the unit test.Thanks for your attention.
In taglib-sharp\src\TagLib\Mpeg4\Boxes\AppleElementaryStreamDescriptor.cs: line 117
AAC_Test.zip

@Magentaize
Copy link
Author

Due to the definition in the latest ISO specification, the "avgBitrate" box should be zero if using VBR. Close.

@shaforostoff
Copy link

this code makes a rough guess about file's bitrate and length:

taglib/taglib#856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants