Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacewar sample disappeared? #16

Closed
SimonDarksideJ opened this issue May 5, 2014 · 5 comments
Closed

Spacewar sample disappeared? #16

SimonDarksideJ opened this issue May 5, 2014 · 5 comments

Comments

@SimonDarksideJ
Copy link
Contributor

@tomspilman not sure what's happened by the files for the Spacewar sample have disappeared from the develop branch?

Odd because that PR was merged a while ago, before NeonShooter.

Should I resubmit the PR for that?
Odd thing is that the .SLN files still point to the missing folder?
@tomspilman
Copy link
Member

You closed that PR...

#11

... I assumed you meant to do that. :)

@SimonDarksideJ
Copy link
Contributor Author

That is odd, I thought I only closed it after it was merged. I'll resubmit then

@SimonDarksideJ
Copy link
Contributor Author

Actually @tomspilman , just looked in the closed PR List and it was merged?
#13

Ideas?

@SimonDarksideJ SimonDarksideJ reopened this May 5, 2014
@tomspilman
Copy link
Member

It seems that in #12 you renamed and/or deleted a bunch of SpaceWar stuff. Maybe you made a mistake when copying the one sample to make the other?

@SimonDarksideJ
Copy link
Contributor Author

Not sure at this point, in any case I've resubmitted the spacewar sample as a new PR based on the current develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomspilman @SimonDarksideJ