Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundEmitterSystem.cpp is a Valve file #10

Closed
monokrome opened this issue Aug 19, 2010 · 2 comments
Closed

SoundEmitterSystem.cpp is a Valve file #10

monokrome opened this issue Aug 19, 2010 · 2 comments

Comments

@monokrome
Copy link
Owner

Valve files should not be included in this project for the following reasons:

  • This aims to be simple to install on any SDK version. Portability should be a high priority. Copying the file from a specific SDK does not guarantee support with later versions, nor does it help with forward-compatibility with the Source SDK. The more code that we need to maintain from Valve's SDK files, the more work will be needed on our end to support new SDK versions or possibly licensed Source games interested in the project.
  • There Source SDK's license seems to be unannounced based on my searching. I'm not sure if we can legally provide modified copies their files.

Instead, we should have a routing class in a file of our own that we can have users include with a few short lines in an installation documentation file explaining the rerouting process and any limitations that maybe be imposed from this method.

@Islandstone
Copy link
Collaborator

The router can't be moved outside of SoundEmitterSystem.cpp because the class CSoundEmitterSystem is defined in the .cpp file itself. This makes it difficult to use this class or a pointer to this class outside of that file. This is necessary for handling the script sounds.

Unless we can redistribute the entire file ourselves, it'll have to be done as part of the installation procedures. There is currently no way as I can see where we'd be able to access CSoundEmitterSystem from outside that file.

@monokrome
Copy link
Owner Author

Alright. That's a bad design decision on Valve's part that we're going to have to roll with and keep the Valve file in our project. Not sure why they would declare that class in the cpp file!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants