Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softcut phase offset #816

Closed
tehn opened this issue Apr 15, 2019 · 3 comments
Closed

softcut phase offset #816

tehn opened this issue Apr 15, 2019 · 3 comments
Labels

Comments

@tehn
Copy link
Member

tehn commented Apr 15, 2019

one feature from the old softcut didn't make it forward: phase_offset

the phase_quant is always relative to 0 (this makes sense), but i'm looking to do weird things (in mlr specifically) where i want to check phase quantum with an offset.

ie, if phase quantum is 0.4s but the loop i'm interested in looking at starts at 1.0s, things don't line up as the start point is not a multiple of the quantum.

my hack for the old softcut was to add the offset command. will re-attempt to dip into crone a bit later.

@catfact
Copy link
Collaborator

catfact commented Apr 15, 2019

so, IIUC, you would add an offset before quantizing, like here?
https://github.com/monome/norns/blob/master/crone/src/softcut/SoftCutVoice.cpp#L187

@tehn
Copy link
Member Author

tehn commented Apr 15, 2019

yep that'd do it i think

thanks for the line #

@tehn
Copy link
Member Author

tehn commented Apr 21, 2019

fixed by #819

@tehn tehn closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants