Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserify chokes #51

Closed
AutoSponge opened this issue Apr 26, 2015 · 1 comment
Closed

browserify chokes #51

AutoSponge opened this issue Apr 26, 2015 · 1 comment

Comments

@AutoSponge
Copy link

I wanted to see what browsers this code supported so I tried to browserify the entry point.

➜  frb git:(master) ✗ browserify bindings.js -o bundle.js
Error: Parsing file /Users/paulgrenier/GitHub/frb/language.js: Line 31: Unexpected string

I was able to get through this by turning "if" into a constant. However, getting the tests to run is significantly harder--there are several references to other reserved words like 'with' and 'delete'.

Is there an expectation that these tests run on the client? If so, which browsers are supported?

@kriskowal
Copy link
Member

I believe that if you pass the bundle through an uglifier/minimizer, the keyword properties will be quoted for older browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants