Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sizes argument in hyp_dots function #35

Closed
kotliary opened this issue Aug 21, 2021 · 1 comment
Closed

sizes argument in hyp_dots function #35

kotliary opened this issue Aug 21, 2021 · 1 comment

Comments

@kotliary
Copy link

kotliary commented Aug 21, 2021

The documentation for hyp_dots function says that sizes argument is "Size dots by geneset sizes". This is true if merge = FALSE.

But if merge = TRUE the size of dots actually corresponds to the significance value (pval or fdr). It took me a while to find it by looking at the code. Please update the documentation.

Also I don't see a reason not to show the size legends by default (if sizes = TRUE).

anfederico added a commit that referenced this issue Aug 25, 2021
@anfederico
Copy link
Collaborator

Just updated the docs - thank you. I think you're right, I will update that function soon to allow sizing by geneset sizes when merging multiple signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants