Remove Empty option handling to fix issue 32 #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I'll try this in a few fairly sized, internal, codebases that make use of Fare and let you know whether this breaks something or not. If all goes fine, this should be merged over the next few days and released on NuGet as well. 🚀 |
moodmosaic
reviewed
Apr 19, 2019
moodmosaic
requested changes
May 13, 2019
|
I'll create a new PR to make it easy. |
|
Sounds good! Thank you, @jburnett. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in RegExp.cs fixes issue 32 by ignoring RegExpOptions.Empty during parsing. Added repo case to XegerTests.cs.
I included the changes target framework I used on MacOS, but you can skip them & test w/.NET Fx and older netcore.