Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow_debugonce doesn't work on obj$fun #93

Open
moodymudskipper opened this issue Feb 23, 2022 · 1 comment
Open

flow_debugonce doesn't work on obj$fun #93

moodymudskipper opened this issue Feb 23, 2022 · 1 comment
Milestone
One day

Comments

@moodymudskipper
Copy link
Owner

moodymudskipper commented Feb 23, 2022 •
edited
Loading

That's annoying if we wish to debug an unexported function, e.g.

flow::flow_debugonce(shiny:::ReactiveVal$new)
@moodymudskipper moodymudskipper added this to the 0.0.2 milestone Mar 4, 2022
@moodymudskipper moodymudskipper changed the title flow_debugonce doesn't work on namespaces functions flow_debugonce doesn't work on namespaced functions Mar 4, 2022
@moodymudskipper moodymudskipper changed the title flow_debugonce doesn't work on namespaced functions flow_debugonce doesn't work on obj$fun Mar 4, 2022
@moodymudskipper
Copy link
Owner Author

This is because we use trace() and unlike debugonce() trace only accepts fun or pkg::fun / pkg:::fun.
I think fixing this requires us to write our version of trace, hard with no huge upside.

@moodymudskipper moodymudskipper modified the milestones: 0.0.2, One day Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
One day
Development

No branches or pull requests
1 participant
@moodymudskipper