Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some glyphs are missing coverage data for certain fonts #38

Closed
hasenbanck opened this issue Oct 15, 2020 · 3 comments
Closed

Some glyphs are missing coverage data for certain fonts #38

hasenbanck opened this issue Oct 15, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@hasenbanck
Copy link

While porting the font renderer for egui to fontdue, I happen to notice that some glyphs are missing the coverage data for a font that egui uses:
https://github.com/emilk/egui/blob/master/egui/fonts/Comfortaa-Regular.ttf

For example the glyph for the character 'b' only has a vector with coverage of "0.0"s, but on the other side, the metrics look fine.

Rusttype doesn't seem to have this problem.

@mooman219
Copy link
Owner

The font defines half of it's glyphs in TrueType, and the other half in OpenType. Some font viewers will have this issue as well because this is fairly wrong all things considered. I'll see what I can do to support it

@mooman219
Copy link
Owner

mooman219 commented Oct 15, 2020

Upon closer inspection, the letter 'b' is actually not to spec for the font. It's a transform of the letter 'd' which leaves the points incorrectly defined (the order of the points matters, and you can't just mirror a glyph and have it keep working). I'll see what I can do to resolve that, but it's definitely going against the spec for the table the letter is defined in.

I did a little writeup here: harfbuzz/ttf-parser#43 (comment)

@mooman219 mooman219 added the bug Something isn't working label Oct 17, 2020
@mooman219
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants