Adds migration for ParachainStaking AtStake to support auto-compound #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
added
B7-runtimenoteworthy
nbaztec
changed the title
librelois
approved these changes
Oct 19, 2022
added 2 commits
October 19, 2022 09:36
…nbeam into nish-auto-compound-migrate
notlesh
reviewed
Oct 19, 2022
|
|
||
| // remove up to 1000 candidates that did not produce any blocks for | ||
| // the given round | ||
| let _ = <AtStake<T>>::clear_prefix(paid_for_round, 1000, None); |
There was a problem hiding this comment.
We could use the value from TopSelected but maybe we don't want an extra read. Alternatively, a constant for this would be good.
If we make our rounds longer, this problem should mostly go away (except for very poorly performing collators...)
There was a problem hiding this comment.
Yeah I struggled to find a constant for this value. But I don't get how increasing the round length would fix this issue, since we only read the points first, then the AtStake
notlesh
approved these changes
Oct 19, 2022
crystalin
added
D9-needsaudit👮
crystalin
changed the title
notlesh
added
D1-audited👍
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
…ing candidates without blocks from rewarded rounds (moonbeam-foundation#1878) * add migration for AtStake * add validations * add migrations to remove the stale AtStake entries before autoCompound migrations * better logs * fix AtStake not cleaned up for candidates not producing blocks * Allow fork test to start from the expected round index Co-authored-by: Crystalin <alan@purestake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds the following migrations:
RemovePaidRoundsFromAtStake- to remove any staleAtStakeentries relating to already paid-out rounds that had candidates that didn't produce any blocks.MigrateAtStakeAutoCompound- migrates the snapshots for unpaid rounds forAtStakeinstead of the on-the-fly-migration viaMigratedAtStakestorage.The fix for stale
AtStakeentries relating to already paid-out rounds that had candidates that didn't produce any blocks, is also included in this PR since it is a pre-requisite to avoid having to runRemovePaidRoundsFromAtStakeover and over again.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?