Drain all AwardedPts after payouts #1880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
reviewed
Oct 19, 2022
| @@ -1532,6 +1532,9 @@ pub mod pallet { | |||
| // clean up storage items that we no longer need | |||
| <DelayedPayouts<T>>::remove(paid_for_round); | |||
| <Points<T>>::remove(paid_for_round); | |||
| // remove any AtStake entries that are left over. this will happen any time a | |||
| // selected collator produces no blocks for the entire round. | |||
| <AtStake<T>>::iter_prefix(paid_for_round).drain().collect(); | |||
There was a problem hiding this comment.
We should use remove_prefix here to avoid reading the value in PoV.
https://crates.parity.io/frame_support/storage/types/struct.StorageDoubleMap.html#method.remove_prefix
Suggested change
| <AtStake<T>>::iter_prefix(paid_for_round).drain().collect(); | |
| <AtStake<T>>::remove_prefix(paid_for_round, None); |
There was a problem hiding this comment.
Actually I included this fix in #1878 since it's a pre-requisite for the migration.
|
Closing because #1878 includes this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes
AtStakeentries that didn't have a correspondingAwardedPtsentry. This happens any time a collator produces no blocks for a round.Note that this is done after the last payout is made.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?