Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 #2377

Agusrodri · 2023-07-04T15:03:46Z

What does it do?

Updates dependencies to v0.9.43

⚠️ Breaking Changes ⚠️

One important change that was introduced in the PR of Deprecate Currency (link also below), is related to reducible and reserve balances. Before this change was introduced, the reserve balance that a user had, wasn't included as part of their reducible balance. Now in v0.9.43 upgrade, the reserve balance is accounted for in the frozen balance.
System.Account chain state call now returns { free, reserved, frozen, flags } inside its data field.

Relevant upstream changes (so far)

Runtime

Client

TODO

Check and cherry-pick moonbeam-foundation/substrate@d59476b

librelois · 2023-07-31T06:55:38Z

the reserve balance that a user had, wasn't included as part of their reducible (transferable) balance. Now in v0.9.43 upgrade, the reserve balance is also considered as something that the user can spend.

There is a confusion here between transferable and Slashable/Reducible balance, these are two different concepts.
The transferable balance change only for chains with a non-zero existential deposit, so the transferable balance not change for moon* chains.

On the other hand, the Slashable/Reducible balance change, because the reserved amount becomes slashable in v0.9.43:

Freezes are essentially the same as locks, except that they overlap with Holds. Since Holds are designed to be infallibly slashed, this means that any logic using a Freeze must handle the possibility of the frozen amount being reduced, potentially to zero.

So to clarify, the amount reserved does not become transferable by the user, but becomes withdrawable by the protocol for slashing. Because we don't have slashing on moon* chains, this change is not breaking for us.

* migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com>

nbaztec · 2023-08-03T15:04:21Z

runtime/moonbase/src/governance/councils.rs

@@ -23,6 +23,11 @@ pub type TechCommitteeInstance = pallet_collective::Instance2;
 pub type TreasuryCouncilInstance = pallet_collective::Instance3;
 pub type OpenTechCommitteeInstance = pallet_collective::Instance4;

+parameter_types! {
+	// TODO: Check value of this parameter


Is this todo actionable right now?

I think the value is correct, it was only a reminder to take a look at it. This is the way in which Polkadot is configured as well.

fgamundi

moonbeam-foundation/substrate@99d69e3 is still cherry picked in the Substrate fork, but it shouldn't be necessary anymore with moonbeam-foundation/substrate@bf27322 (also cherrypicked). Should we remove it, or keep it for now? It doesn't really hurt us to keep it

girazoki · 2023-08-03T16:08:35Z

precompiles/assets-erc20/src/tests.rs

@@ -267,7 +267,7 @@ fn approve() {
 						value: 500.into(),
 					},
 				)
-				.expect_cost(32317756)
+				.expect_cost(36430756)


We should aim at not modifying these every runtime upgrade. Perhaps matching it directly to the weight expected would be a good thing..maybe for another issue

girazoki · 2023-08-03T16:09:54Z

precompiles/balances-erc20/src/tests.rs

-		.with_balances(vec![(CryptoAlith.into(), 1000)])
+		.with_balances(vec![
+			(CryptoAlith.into(), 1000),
+			(CryptoBaltathar.into(), 1000),


AFAICT baltathar is not needed?

Baltathar is needed to reflect the correct behavior of the test. If we only leave Alith, we encounter some discrepancy with the TotalIssuance, having some AritmeticUnderflow error instead of the error that we are looking for. With Baltathar there, the TotalIssuance is greater than Alith's balance so we don't have trouble to test the desired functionality. This change was introduced in v0.9.43 and it's related to Currency deprecation.

Another solution could be to manually set the TotalIssuance, but both approaches are correct in my opinion.

girazoki

lgtm

* Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 (#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> * fix CI * changes * fix CI * fixed some tests * more test fixes * fixed tests * lint * editor config * pkg fix --------- Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com> Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

* Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 (#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> * fix CI * changes * fix CI * fixed some tests * more test fixes * fixed tests * lint * editor config * pkg fix --------- Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com> Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

* Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 (#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> * fix CI * changes * fix CI * fixed some tests * more test fixes * fixed tests * lint * editor config * pkg fix --------- Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com> Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

* Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 (#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com> * fix CI * changes * fix CI * fixed some tests * more test fixes * fixed tests * lint * editor config * pkg fix --------- Co-authored-by: Agustín Rodriguez <agus@moonsonglabs.com> Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

#2377) * begin upgrade to v0.9.43 * make client/vrf compile * make pallet-author-mapping compile * make pallet-erc20-xcm-bridge compile * make primitives/session-keys compile * fix test in pallet-parachain-staking * make pallet-moonbeam-orbiters compile * make pallet-asset-manager compile * fix dependencies * make pallet-xcm-transactor compile * make pallet-migrations compile * make pallet-randomness compile * fix schnorrkel in randomness * enable insecure_zero_ed flag * update frontier fork * use moonbeam forks * impl TypeInfo for TxPoolResponse * use our evm fork * AssetId non-Copy * make moonbase runtime compile * moonbeam runtime compiles * moonriver runtime compiles * start fixing client & node * fix frontier sql * fix mocks * fix relay-encoder * fix pallet-ethereum dep * prepare moonbase mocks & tests * prepare moonbeam mocks & tests * prepare moonriver mocks & tests * fix integration tests (costs) * fix node service * fix xcm tests * update cumulus pin * Merge branch 'master' into upgrade-v0.9.43 * remove changes in settings.json * fix rpc-port in dev & para node * fix randomness benchmarks * enable newRpcBehaviour on Moonwall * fmt * update moonkit pin * make tests compile with runtime-benchmarks feature * Update node invocations to use rpc-port instead of ws-port (#2388) * Update node invocations to use rpc-port instead of ws-port * Prettier * Removed unneeded options from moonwall config * Removed unused arg * Cargo.toml files fmt * Update RelayEncoder to be 9430 compatible (#2376) * Update RelayEncoder stake calls to latest changes * fmt * Naming * fmt * Fix tests * Completely removed old calls * fmt * Update Solidity contract * Updated tests * Review * Updated tests * fmt * Prettier * Prettier * Updated encodeNominate param type --------- Co-authored-by: Francisco Gamundi <francisco@purestake.com> * Updated encodeSetPayee selector * clippy fixes in moonkit * clippy fixes in moonbeam * fix some rust benchmark tests * fix genesis balance for TS tests * fix some TS tests * fix fees & gas cost in TS tests * fix rust tests * Upgrade polkadot-js and support weight v2 for fees * update substrate & frontier pin * WasmExecutor ignore onchain heap pages * Fix moonwall chopsticks test * Fix zombie * moonwall dev fixes * restored APIs * add provider to chospticks storage * update polkadot pin * remove wasm overrideP * update substrate pin to fix pov tests * fix test * eth test fix * prettier * chopsticks fixes * disabled test * fix reducible balance TS test * fix moonwall * changed base ext weight * fix eth-tx-types TS tests * fix precompile assets-erc20 TS tests * status.isFrozen fix in precompile TS tests * fix test-txpool-fairness * fix proxy-governance TS tests * prettier * adjusted fillBlock input param * update frontier pin * fix fee-multiplier TS test * fix test-filter-api-pending * ED of zero in more mocks * remove unnecessary clone * change test-staking-locks timeout * change timeout in test-precompile-referenda * timeout again * upgrade rust to 1.71 * fix rust warning: unused mut * update substrate pin * proposer: enable feature ensure_proof_size_limit_after_each_extrinsic * fix clippy warnings * fix rust tests compilation * timeout * migrate to moonkit (#2384) * migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com> * minor changes --------- Co-authored-by: librelois <c@elo.tf> Co-authored-by: Nisheeth Barthwal <nbaztec@gmail.com> Co-authored-by: Francisco Gamundi <52399794+fgamundi@users.noreply.github.com> Co-authored-by: Crystalin <alan@moonsonglabs.com> Co-authored-by: Francisco Gamundi <francisco@purestake.com> Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com> Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com> Co-authored-by: girazoki <gorka.irazoki@gmail.com>

Agusrodri and others added 24 commits June 22, 2023 15:43

begin upgrade to v0.9.43

1dadcc2

make client/vrf compile

c74aacc

make pallet-author-mapping compile

61383a4

make pallet-erc20-xcm-bridge compile

3e738a8

make primitives/session-keys compile

443ec68

fix test in pallet-parachain-staking

73a6d1a

make pallet-moonbeam-orbiters compile

e5f1a21

make pallet-asset-manager compile

78d726e

fix dependencies

2b35cc8

make pallet-xcm-transactor compile

035796d

make pallet-migrations compile

eddcf68

make pallet-randomness compile

427822a

fix schnorrkel in randomness

708a008

enable insecure_zero_ed flag

5cda069

update frontier fork

3d80b7d

use moonbeam forks

ddf7d06

impl TypeInfo for TxPoolResponse

385ec5b

use our evm fork

6ad0b0e

AssetId non-Copy

cd004d5

make moonbase runtime compile

983f5a2

moonbeam runtime compiles

4a6fe91

moonriver runtime compiles

1c0106d

start fixing client & node

48d0e0b

fix frontier sql

ddcf58e

Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Jul 4, 2023

Agusrodri added 3 commits July 4, 2023 13:12

fix mocks

94bc4eb

fix relay-encoder

8bf3f5b

fix pallet-ethereum dep

a818904

fix rust tests compilation

5a07bb7

Agusrodri and others added 4 commits July 31, 2023 11:42

timeout

ea8ab7e

migrate to moonkit (#2384)

01b5cf9

* migrate to moonkit * make it compile * fix rust tests & clippy --------- Co-authored-by: agus <agusrodriguez2456@gmail.com>

Merge branch 'master' into upgrade-v0.9.43

b2b8b23

minor changes

8de0ace

librelois approved these changes Aug 3, 2023

View reviewed changes

nbaztec reviewed Aug 3, 2023

View reviewed changes

fgamundi reviewed Aug 3, 2023

View reviewed changes

girazoki reviewed Aug 3, 2023

View reviewed changes

girazoki approved these changes Aug 3, 2023

View reviewed changes

Agusrodri merged commit 93548ee into master Aug 3, 2023
26 checks passed

Agusrodri deleted the upgrade-v0.9.43 branch August 3, 2023 16:57

notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Aug 16, 2023

noandrea added the B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes label Sep 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 #2377

Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 #2377

Agusrodri commented Jul 4, 2023 •

edited by crystalin

librelois commented Jul 31, 2023 •

edited

nbaztec Aug 3, 2023

Agusrodri Aug 3, 2023 •

edited

fgamundi left a comment •

edited

girazoki Aug 3, 2023

girazoki Aug 3, 2023

Agusrodri Aug 3, 2023 •

edited

Agusrodri Aug 3, 2023

girazoki left a comment

Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 #2377

Dependency (Substrate/Polkadot/Frontier/Cumulus/...) update to v0.9.43 #2377

Conversation

Agusrodri commented Jul 4, 2023 • edited by crystalin

What does it do?

⚠️ Breaking Changes ⚠️

Relevant upstream changes (so far)

Runtime

Client

TODO

librelois commented Jul 31, 2023 • edited

nbaztec Aug 3, 2023

Choose a reason for hiding this comment

Agusrodri Aug 3, 2023 • edited

Choose a reason for hiding this comment

fgamundi left a comment • edited

Choose a reason for hiding this comment

girazoki Aug 3, 2023

Choose a reason for hiding this comment

girazoki Aug 3, 2023

Choose a reason for hiding this comment

Agusrodri Aug 3, 2023 • edited

Choose a reason for hiding this comment

Agusrodri Aug 3, 2023

Choose a reason for hiding this comment

girazoki left a comment

Choose a reason for hiding this comment

Agusrodri commented Jul 4, 2023 •

edited by crystalin

librelois commented Jul 31, 2023 •

edited

Agusrodri Aug 3, 2023 •

edited

fgamundi left a comment •

edited

Agusrodri Aug 3, 2023 •

edited