Fix try-runtime pre/post hook (#2553) #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimbi
force-pushed
the
cem-pre-post-upgrade
branch
from
17a6c00
to
402d8ac
Compare
|
@rimbi I merged the moonkit PR, can you upgrade the moonkit hash on Cargo.lock? |
rimbi
added
B7-runtimenoteworthy
librelois
approved these changes
Sep 5, 2023
crystalin
approved these changes
Sep 5, 2023
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix try-runtime pre/post hook execution issue. After the changes in substrate at this PR the
pre_upgradeandpost_upgradehooks stopped executing. This PR introduces the necessary changes to fix the issue.What important points reviewers should know?
Is there something left for follow-up PRs?
It also has a complementary PR at the Moonkit repo.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?