Allow setting Unlimited for BuyExecution in XCM Transactor #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B7-runtimenoteworthy
Agusrodri
changed the title
librelois
reviewed
Nov 7, 2023
asiniscalchi
pushed a commit
to asiniscalchi/moonbeam
that referenced
this pull request
Nov 10, 2023
…undation#2475) * Fix try-runtime pre/post hook (moonbeam-foundation#2553) * Update moonkit rev in Cargo.lock * Make the same changes in moonbase and moonriver runtimes
librelois
reviewed
Nov 28, 2023
librelois
reviewed
Nov 28, 2023
librelois
reviewed
Nov 28, 2023
librelois
reviewed
Nov 28, 2023
librelois
reviewed
Nov 28, 2023
Coverage Report@@ Coverage Diff @@
## master agustin-unlimited-buy-execution +/- ##
===================================================================
- Coverage 81.90% 81.88% -0.02%
Files 286 286
+ Lines 95261 95320 +59
===================================================================
+ Hits 78018 78049 +31
+ Misses 17243 17271 +28
|
librelois
approved these changes
Dec 8, 2023
ahmadkaouk
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Modifies the
overall_weightfield insideTransactWeightsstruct ofpallet-xcm-transactorto allow settingUnlimitedas the total weight to buy in the destination chain.It also adds the possibility of using
Unlimitedthrough the XCM Transactor precompile V3. To do this, auint64::MAXshould be passed through therefTimefield of theoverall_weightparameter in the desired function of the precompile's smart contract.