Unified client for regular and tracing nodes #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
B5-clientnoteworthy
# Conflicts: # .github/workflows/build.yml # Cargo.lock # node/Cargo.toml # node/cli/src/command.rs # node/service/Cargo.toml # node/service/src/chain_spec/mod.rs # node/service/src/lib.rs # node/service/src/rpc.rs # primitives/ext/Cargo.toml # primitives/rpc/debug/Cargo.toml # primitives/rpc/evm-tracing-events/src/runtime.rs # runtime/common/src/apis.rs # runtime/evm_tracer/Cargo.toml # runtime/evm_tracer/src/lib.rs # runtime/moonbase/Cargo.toml # runtime/moonbeam/Cargo.toml # runtime/moonriver/Cargo.toml
tgmichel
changed the title
tgmichel
added
A3-inprogress
tgmichel
added
A0-pleasereview
crystalin
approved these changes
Sep 20, 2021
crystalin
added
A6-seemsok
|
Is the runtime changed for that ? |
tgmichel
force-pushed
the
jeremy-tracing-client-substitutes-support
branch
from
a2fcc67
to
695b082
Compare
Merged
librelois
reviewed
Sep 23, 2021
| @@ -101,26 +102,26 @@ pub struct RawStepLog { | |||
|
|
|||
| #[derive(Clone, Eq, PartialEq, Debug, Encode, Decode)] | |||
| #[cfg_attr(feature = "std", derive(Serialize))] | |||
| #[cfg_attr(feature = "std", serde(rename_all = "camelCase", tag = "type"))] | |||
| #[cfg_attr(feature = "std", serde(rename_all = "lowercase", tag = "type"))] | |||
| pub enum CallInner { | |||
| #[cfg_attr(feature = "std", serde(rename_all = "camelCase"))] | |||
There was a problem hiding this comment.
It is not readable to mix lowercase and camelCase. It is better to use neither of them and to rename specifically the only 2 fields to rename (call_type and SelfDestruct).
There was a problem hiding this comment.
I will sneak this in #847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This is a follow-up on substitute branches for tracing and removes
evm-tracingfeature from the client. Instead we now will use the same client for all nodes, and use substitute runtimes built with theevm-tracingenabled.What important points reviewers should know?
DebugRuntimeApiversions are now removed from the client, and this Api is expected to be accessed only through substitutes.