-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apache Royale nightly build download to Getting Started #12
Comments
Issue has been moved from Moonshine repository. Following comment has been araised Moonshine-IDE/Moonshine-IDE#594 (comment) |
In my opinion there shouldn't be any new entrance on the list. Existing entrance should have radio button which indicates Nightly/Release version. Other framework may have also nightly builds, so in that way we will be prepared for adding nightly to them as well. |
@rat-moonshine Is it working ? If it is how ? I don't see in your provided Installer 3.3.1 any option to download nightly build. |
I don't think I had time to work on this yet, @piotrzarzycki21 . |
- Populates dropdown logic to item-renderer - Checks installed paths based on variant dropdown changes (reference #12)
…ange - UI updation based on variant change - Tested working download (reference #12)
Small updates on this:
At the end of download completion of nightly, I'm having one I/OError which I needs to investigate. Other than this, some CSS styling needs to be done to one of the element. |
- Style updated (reference #12)
Download variants now introduced to SDK-Intaller. We can now declare multiple types of variant from this given list.
Nightly build chose to download from following locations (without defining any build-number): |
@rat-moonshine Could email me and Adrian link to new installer ? |
Sorry. I was in expression that the Bamboo plans also has a nightly deployable plan attached, which is not. I sent you an email to download links. |
We need to finally have Nightly build for Installer!!! |
I meant deploy-somewhere-as-build on Bamboo, as we have for Moonshine. |
I did a test with this build. It seems to work, but after some discussion with @rat-moonshine, I found that this will only download the nightly build once - afterwards, it sees that the MoonshineSDKs/Royale_SDK/apache-royale-0.9.7-bin-js directory already exists, and reports that it is installed. Thinking more about this, there are a couple use case details I want to clarify with @rat-moonshine and @piotrzarzycki21:
If we need to re-download the nightly builds, we can use designs like these:
As for multiple nightly builds, currently the SDK selector looks like this. I can't easily tell which nightly build is with without expanding the width to see the full path. Adding a date in the description would help, but this label is currently read the descriptor file. |
I was thinking about that as well today.
In my opinion the answer is - yes we should allow user download Nightly build. However I don't think it should be based on some timestamp or any kind of mechanism. I would rather give to the user mechanism for removing Nightly build from disk drive.
Having my opinion in mind - no automatic clean up - Let user decide whether he/she wanted to remove SDK.
It think it should point to stable version. It would be great to point to Nightly if stable is download if it's not so problematic to implement.
I would like to avoid download and overwrite folder with sdk by new folder. Like I said I'm in favor of having some way in the UI where user can remove SDK from hard drive. |
- Added logic to show re-download option for Royale nightly - Added logic to re-download after deletion of existing folder (reference #12)
Okay. I did some updates, give a test if this suits to our needs.
Here's a visual when re-download option is available: Here's the latest build for a test: |
It seems like it's the license description only, which is general for both the variant types. If it is Okay, can we think about any general description value instead of mentioning version figure? For the label in left-pane, I shall look into. |
NO it's not the license. It downloads 0.9.6 SDK instead 0.9.7. |
I confirm the break. Apparently it's turned out that I missed some crucial settlement before moving for the download. Thanks for the close observation @piotrzarzycki21 . This should be fixed now. You can try by same download URL again, https://spaces.hightail.com/space/dhMpju9MTw. One UI glitch to note - in "By Feature" section the label to the item squeeze when re-download option appears, expanding the application width however fix the problem for now. I will check this this sometime soon: |
@JoelProminic could you please take a look into spelling of message when we deleting royale folder. It looks like that now: |
Issue gone. I was able re download SDK 0.9.7 without the problem. |
@piotrzarzycki21, is this behavior good enough for your needs? This seems pretty simple and straightforward to me, but it doesn't have some of the control we were talking about earlier. I would like to be able to see the date for the last nightly build. We could check the created or modified timestamp on one of the files, or I see a timestamp in the element of royale-asjs/flex-sdk-description.xml
A tooltip would probably be sufficient. Alternatively, we could display it in the UI, but shorten it down to the month and day (i.e. Jan 28), or just the year for builds older than a year, to keep the label compact. |
Yeah, it is enough good. We can capture further improvements in the next tickets. |
Could you provide newest installer, cause I see you have made some updates. I think we are enough good to have it close - Aren't we ? |
Rather than display the "Created On" link with a tool tip, I think we should just display "Installed ". If the full timestamp won't fit in the UI, then you can abbreviate it (i.e. Jan 29, 2020 or just Jan 29) and show the full timestamp in a tooltip. The date should be sufficient for the display, but some power users like Piotr may need to see the full time. If you can do it easily, add the timestamp to the "installed" icon as well. |
Could you also place that tooltip over download icon in "By Softwer" ? |
I thought about that, but it'd be redundant. Either we choose over date-label or installed-icon. Perhaps, over installed icon only would keep things similar between "By Feature" (?) |
When I'm going to Installer I won't roll over "Installed..." world - I wouldn't even think about that, so user wouldn't as well. You will have your mouse cursor more often in the area of download icon. Even more when you roll over download icon this tooltip should say "Installed full date" - cause I wouldn't know what is all about - If I see only date. |
That seems also fits my earlier thought on keeping similarity. I shall move the tooltip to installed icon then with pre-text 'Installed'. |
You can test latest builds from https://spaces.hightail.com/space/dhMpju9MTw using the above changes and the break reported by @piotrzarzycki21 recently where Gradle download URL failing (fixed). |
Gradle download is working. I think we are done with that issue. Close it. |
It's been tested so I'm closing it. |
@rat-moonshine this should be first priority adding Nightly Build for next release. Another user come to Moonshine and first thing which he did he download 0.9.4 SDK which is definitely outdated and had problem with building newest examples.
The text was updated successfully, but these errors were encountered: