Skip to content

Fx.Slide show() fixed height no resetHeight #1107

Open
doekenorg opened this Issue Feb 29, 2012 · 5 comments

2 participants

@doekenorg

Mootools-More 1.4.0.1

When an item is shown via document.id('element').slide('show') the height is fixed. This is because the complete event isn't triggered so even if the resetHeight options is set to true, the height does not get changed to 'auto'.

Not certain if this is considered a bug, but it is still quite annoying.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@arian
MooTools member
arian commented Feb 29, 2012

Looks like it does reset the height property: http://jsfiddle.net/K5JuM/2/

@doekenorg

When you do a transition there is no problem. It's without the transition thats a problem for me: http://jsfiddle.net/2YW4v/3/

The wrapper now has a fixed height of 180px (in Chrome)

@arian
MooTools member
arian commented Feb 29, 2012

ah, good point..

@arian
MooTools member
arian commented Feb 29, 2012

Probably these lines https://github.com/mootools/mootools-more/blob/d847456e5b/Source/Fx/Fx.Slide.js#L59-60 should go in a separate method, and that method should be called by the onComplete event and by the show() and hide() methods.

@doekenorg

That would fix this issue I guess. But two things are unclear to me. Where is the onComplete event being triggered? And why shouldn't show() and hide() trigger this event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.