Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Assets package to Asset #1334

Closed
masted opened this issue Nov 8, 2015 · 6 comments
Closed

Rename Assets package to Asset #1334

masted opened this issue Nov 8, 2015 · 6 comments

Comments

@masted
Copy link
Contributor

masted commented Nov 8, 2015

I'm writing tool for auto-building mootools dependencies by parsing code. And I have a problem with Object "Asset". It named in meta-data comments as "Assets". Why it was made like that? And can we rename Assets "package" to Asset?

@SergioCrisostomo
Copy link
Member

If its a pattern that all other modules have then I guess we should change it. Lets see what others say.

@arian
Copy link
Member

arian commented Nov 9, 2015

We could add Asset.image, Asset.javascript, Asset.css to the provides.

On the other hand, the requires / provides are supposed to match, we don't guarantee anywhere that this provided name actually matches some javascript variable name.

@SergioCrisostomo
Copy link
Member

Good idea @arian.

@masted if you use provides: [Asset.image, Asset.javascript, Asset.css] in this line can your work with that in your tool?

@masted
Copy link
Contributor Author

masted commented Nov 10, 2015

Yes. It would be enough

@anutron
Copy link
Member

anutron commented Nov 10, 2015

Note that provides (as we original envisioned it) does provide things that don't match necessarily. For example:

provides: [Class.Extras, Chain, Events, Options]

We also at some point (though I can't remember where) used this for deprecated names (i.e. some new feature replaced and old one and provided backwards compat for the old one, so it provided that thing too).

I think it's fine to provide numerous things. Here's another example where the filename is (by convention) Class.Refactor but the thing provided is a function, so it defines Class.refactor. So the provision is:

provides: [Class.refactor, Class.Refactor]

@SergioCrisostomo
Copy link
Member

Fixed in #1335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants