-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Assets package to Asset #1334
Comments
If its a pattern that all other modules have then I guess we should change it. Lets see what others say. |
We could add On the other hand, the requires / provides are supposed to match, we don't guarantee anywhere that this provided name actually matches some javascript variable name. |
Yes. It would be enough |
Note that provides (as we original envisioned it) does provide things that don't match necessarily. For example:
We also at some point (though I can't remember where) used this for deprecated names (i.e. some new feature replaced and old one and provided backwards compat for the old one, so it provided that thing too). I think it's fine to provide numerous things. Here's another example where the filename is (by convention)
|
Fixed in #1335 |
I'm writing tool for auto-building mootools dependencies by parsing code. And I have a problem with Object "Asset". It named in meta-data comments as "Assets". Why it was made like that? And can we rename Assets "package" to Asset?
The text was updated successfully, but these errors were encountered: