Fix Slick.getAttribute, expose Slick.hasAttribute so it can be used as MooTools getProperty #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is sweet. @subtleGradient what do you say? |
|
As shown here, http://jsfiddle.net/arian/Hd3hd/, leaving |
| @@ -185,12 +185,12 @@ local.setDocument = function(document){ | |||
| // getAttribute | |||
|
|
|||
| features.getAttribute = (features.isHTMLDocument && brokenFormAttributeGetter) ? function(node, name){ | |||
| var method = this.attributeGetters[name]; | |||
| var method = this.attributeGetters[name.toLowerCase()]; | |||
There was a problem hiding this comment.
This is a performance issue.
If you need this, add it to the code that calls this method.
|
Looks good. All except the |
|
Alternatively you could add all the various cases to the object as references to the same getter. |
|
ah, yeah good idea, will fix it in a minute! |
… the document is set when using Slick.getAttribute
|
@subtleGradient merge it :) |
subtleGradient
added a commit
that referenced
this pull request
Aug 12, 2011
Fix Slick.getAttribute, expose Slick.hasAttribute so it can be used as MooTools getProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maxLength to attributes. Expose Slick.hasAttribute and makes sure the document is set when using Slick.getAttribute