Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle funds type fields #53

Closed
barszcz opened this issue Jan 10, 2023 · 0 comments · Fixed by #59
Closed

Correctly handle funds type fields #53

barszcz opened this issue Jan 10, 2023 · 0 comments · Fixed by #59
Labels
bug Something isn't working

Comments

@barszcz
Copy link

barszcz commented Jan 10, 2023

Bai2 Version: 0.1.0

What were you trying to do?

What did you expect to see?

What did you see?

How can we reproduce the problem?

This is a follow-on from #52. Right now the library doesn't properly handle funds types (see page 30 of [the spec]), instead coalescing all fields from funds type onward in a given record into a slice of strings.

Ideally we would have some kind of rich type here that captures all the detail in this. For a first pass just grabbing a slice of strings might be fine, as long as we can distinguish them from the fields that come after them in 16 (transaction detail) records.

Also I just discovered that 03 (account identifier) records can have more than one of these. It can have the sequence of (type code, amount, item count, funds type) once per type code, an arbitrary number of times. I'll open another issue to address that as well.

@adamdecaf adamdecaf added the bug Something isn't working label Jan 11, 2023
@mfdeveloper508 mfdeveloper508 linked a pull request Feb 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants