Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtp: expose serial generator as a function, with helpers #61

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

adamdecaf
Copy link
Member

I've adapted the two below PR's into a more general approach and added it for every serial function.

See #59 and #60

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.65%. Comparing base (8d3bebe) to head (c1c66b0).

❗ Current head c1c66b0 differs from pull request most recent head c8db072. Consider uploading reports for the commit c8db072 to get more accurate results

Files Patch % Lines
pkg/rtp/serials.go 87.50% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   84.42%   84.65%   +0.22%     
==========================================
  Files          13       13              
  Lines         199      215      +16     
==========================================
+ Hits          168      182      +14     
- Misses         26       27       +1     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf merged commit 08b1070 into master Mar 20, 2024
6 checks passed
@adamdecaf adamdecaf deleted the serial-functions branch April 18, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants