Fix: Ensure Unique AdmnMessageID() Generation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised AlphaSerialNumber function to guarantee unique message ID generation even when multiple IDs are created at the same time. By eliminating the dependency on the current time, this fix ensures that message IDs remain distinct regardless of generation timing. This adjustment enhances system robustness and mitigates potential conflicts in message identification.
|
I like this, but we knew that time based sequences will conflict. Random numbers will still conflict and will produce out-of-sequence values, which may be unexpected. Perhaps we offer a version of these ID functions which take a generator function. |
|
Thanks for opening these PR's. I've opened #61 which is a bit more generic and applies to every serial number as they all need this fix. I've included a serial generator using crypto/rand as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the AlphaSerialNumber function to guarantee unique message ID generation even when multiple IDs are created simultaneously. By eliminating the dependency on the current time, this fix ensures that message IDs remain distinct regardless of generation timing. This adjustment mitigates potential conflicts in message identification. This function is called inside AdmnMessageID(). (The issue will occur when you have two sets of queues and you are trying to echo at the same time in both queues. Generated message IDs will be exactly the same if they depend on time.)