Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media library timeout is always 10.000 #129

Closed
eyadsibai opened this issue Jan 25, 2017 · 9 comments
Closed

Media library timeout is always 10.000 #129

eyadsibai opened this issue Jan 25, 2017 · 9 comments
Labels
C-bug Category: This is a bug
Milestone

Comments

@eyadsibai
Copy link

eyadsibai commented Jan 25, 2017

if I modify the timeout in the config this is not being reflected. still I get timeout after 10 secs when I try to load the media library for example.

@kingosticks
Copy link
Member

We only seem to use the configured timeout for loading a track before we try and play it. Every other use of load is called with no arguments and hence uses pyspotify's default timeout of 10 seconds.

Lots of people do hit this but it's usually a sign that sometime else is wrong (i.e. something at Spotify's end) since a 10 second timeout is really quite long. But we should fix it, good spot.

@jaedb
Copy link

jaedb commented Mar 15, 2017

A good example of a genuine use case where 10s is not enough is when we want to play a playlist URI. 10 seconds would suffice for getting single objects, but a playlist lookup may be 100+ tracks.

For example: jaedb/Iris#36

@eyadsibai
Copy link
Author

What's the status of this project?

@jaedb
Copy link

jaedb commented Mar 15, 2017

@eyadsibai To which project do you refer?

@eyadsibai
Copy link
Author

eyadsibai commented Mar 15, 2017

this project

@oblitum
Copy link

oblitum commented May 27, 2017

Can't browse and play any playlist from Genres & Moods, always timing out.

@oblitum
Copy link

oblitum commented May 27, 2017

Well, even after applying #139, no luck trying to browse Genres & Moods playlists...

@kingosticks
Copy link
Member

@oblitum you are seeing #133

@jodal
Copy link
Member

jodal commented Jun 7, 2017

Fixed by PR #139.

@jodal jodal closed this as completed Jun 7, 2017
@jodal jodal added this to the v3.1 milestone Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

5 participants