Update subscription option handling to account no local #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
commented
Feb 3, 2024
Comment on lines
+685
to
+693
| if (sub.option().isNoLocal()) { | ||
| if (publisherClientId.equals(sub.getClientId())) { | ||
| // if noLocal do not publish to the publisher | ||
| continue; | ||
| } | ||
| collector.add(sub); | ||
| } else { | ||
| collector.add(sub); | ||
| } |
There was a problem hiding this comment.
This is the main part of the change.
|
@hylkevds sorry for the review ping, I thought that assigning a reviewer would trigger the CI. |
andsel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Implements handling of noLocal subscription option on MQTT5 connections.
What does this PR do?
noLocalin the target subscription.Why is it important/What is the impact to the user?
noLocaloption is handled.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
Use cases