Allowing access to the OS version #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejhanslik
added a commit
that referenced
this pull request
Nov 6, 2013
Allowing access to the OS version
|
Awesome. Thanks. |
|
Thanks @ondrejhanslik. For future reference, I'd prefer us using the new obj-C literals for arrays and dicts. They are supported on all runtimes and reduce the amount of boilerplate quite a bit. |
|
Happy to submit a new PR with literals. I was just sticking to the current syntax and didn't want to rock the boat too much with new syntax. I'd be the first to admit that I'm not all that familiar with mac development either, so I played it safe and just stuck with NSDictionary/NSArray syntax. |
|
No worries. If you feel motivated I'd be very happy to take the PR. |
|
Hey Pete. See #255 for an updated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing access to the OS version