Add ZipMap #763

matachi · 2020-10-01T20:13:33Z

Implementation of ZipMap proposed in #661.

viceroypenguin · 2022-07-20T15:59:17Z

FYI: This operator has been included in SuperLinq 4.0.0, which has now been published.

viceroypenguin · 2023-04-01T14:41:41Z

MoreLinq/ZipMap.cs

@@ -0,0 +1,61 @@
+#region License and Terms
+// MoreLINQ - Extensions to LINQ to Objects
+// Copyright (c) 2008 Jonathan Skeet. All rights reserved.


Notice has incorrect date and author

Right. Should be changed to:

Suggested change

// Copyright (c) 2008 Jonathan Skeet. All rights reserved.

// Copyright (c) 2020 Daniel Jonsson. All rights reserved.

atifaziz

@matachi Thanks for contributing this and sorry for having taken so long to get back with a review. Usually, I don't pay attention to a new PR unless the CI build errors are fixed. Anyway, since master had moved on considerably since this PR was opened, I've aligned it with a merge and added my review. Hope you'll find the time to address the comments soon.

atifaziz · 2023-04-01T17:39:00Z

MoreLinq.Test/ZipMapTest.cs

+        [Test]
+        public void ZipMapIsLazy()
+        {
+            _ = new BreakingSequence<object>().ZipMap(o => o);


This could be more strict here:

Suggested change

_ = new BreakingSequence<object>().ZipMap(o => o);

_ = new BreakingSequence<object>().ZipMap(BreakingFunc.Of<object, object>());

atifaziz · 2023-04-01T17:42:38Z

MoreLinq.Test/ZipMapTest.cs

+        public void ZipMapEmptySequence()
+        {
+            object[] objects = {};
+            var result = objects.ZipMap(o => o);


This could be more strict:

Suggested change

var result = objects.ZipMap(o => o);

var result = objects.ZipMap(BreakingFunc.Of<object, object>());

atifaziz · 2023-04-01T17:45:59Z

MoreLinq.Test/ZipMapTest.cs

+        [Test]
+        public void ZipMapEmptySequence()
+        {
+            object[] objects = {};


Use TestingSequence<> as the source since that asserts on disposal that ZipMap disposed it:

Suggested change

object[] objects = {};

using var objects = Enumerable.Empty<object>().AsTestingSequence();

atifaziz · 2023-04-01T17:46:57Z

MoreLinq.Test/ZipMapTest.cs

+        [Test]
+        public void ZipMapStrings()
+        {
+            string[] strings = { "foo", "bar", "baz" };


Use TestingSequence<> as the source since that asserts on disposal that ZipMap disposed it:

Suggested change

string[] strings = { "foo", "bar", "baz" };

using var strings = TestingSequence.Of("foo", "bar", "baz");

atifaziz · 2023-04-01T17:47:39Z

MoreLinq.Test/ZipMapTest.cs

+        [Test]
+        public void ZipMapFromSequence()
+        {
+            var result = MoreEnumerable.Sequence(5, 8).ZipMap(i => i % 2 == 0);


Use TestingSequence<> as the source since that asserts on disposal that ZipMap disposed it:

Suggested change

var result = MoreEnumerable.Sequence(5, 8).ZipMap(i => i % 2 == 0);

using var xs = TestingSequence.Of(5, 6, 7, 8);

var result = xs.ZipMap(i => i % 2 == 0);

atifaziz · 2023-04-01T17:55:32Z

MoreLinq/ZipMap.cs

+        /// Applies a function on each element and returns a sequence of
+        /// tuples with the source element and the result from the function.


Suggested change

/// Applies a function on each element and returns a sequence of

/// tuples with the source element and the result from the function.

/// Applies a function on each element of the sequence and returns a

/// sequence of tuples with the source element and the result from the

/// function.

atifaziz · 2023-04-01T17:56:45Z

MoreLinq/ZipMap.cs

+        /// ("foo", false"), ("bar", true) and ("baz", true), in turn.
+        /// </example>
+
+        public static IEnumerable<(TSource Item, TResult Result)> ZipMap<TSource, TResult>(


I think the first tuple element should be named Source or Input instead of Item. Thoughts?

atifaziz · 2023-04-01T18:04:41Z

MoreLinq/ZipMap.cs

+            foreach (var item in source)
+            {
+                yield return (item, func(item));
+            }


The NullArgumentTest tests are breaking. The fix is to validate the arguments eagerly and wrap the iterator in a local function as follows (otherwise arguments are validated when the sequence is iterated rather than when ZipMap is called):

Suggested change

foreach (var item in source)

{

yield return (item, func(item));

}

return _(); IEnumerable<(TSource, TResult)> _()

{

foreach (var item in source)

{

yield return (item, func(item));

}

}

atifaziz · 2023-04-01T18:05:05Z

README.md

+### ZipMap
+
+Returns a sequence of tuples containing the source elements and the result of
+a function applied on each element.


Suggested change

a function applied on each element.

a function applied to each element.

atifaziz · 2023-04-01T18:06:38Z

MoreLinq/ZipMap.cs

@@ -0,0 +1,61 @@
+#region License and Terms
+// MoreLINQ - Extensions to LINQ to Objects
+// Copyright (c) 2008 Jonathan Skeet. All rights reserved.


Add ZipMap

d4e12a1

viceroypenguin mentioned this pull request Jun 13, 2022

ZipMap viceroypenguin/SuperLinq#7

Closed

atifaziz added 2 commits April 1, 2023 16:35

Refresh generated code

05c210e

Merge remote-tracking branch 'upstream/master' into zipmap

0e9a406

viceroypenguin reviewed Apr 1, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into zipmap

ac093b4

atifaziz requested changes Apr 1, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ZipMap #763

Add ZipMap #763

matachi commented Oct 1, 2020

viceroypenguin commented Jul 20, 2022

viceroypenguin Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz left a comment

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

atifaziz Apr 1, 2023

	// Copyright (c) 2008 Jonathan Skeet. All rights reserved.
	// Copyright (c) 2020 Daniel Jonsson. All rights reserved.

	_ = new BreakingSequence<object>().ZipMap(o => o);
	_ = new BreakingSequence<object>().ZipMap(BreakingFunc.Of<object, object>());

	var result = objects.ZipMap(o => o);
	var result = objects.ZipMap(BreakingFunc.Of<object, object>());

	object[] objects = {};
	using var objects = Enumerable.Empty<object>().AsTestingSequence();

	string[] strings = { "foo", "bar", "baz" };
	using var strings = TestingSequence.Of("foo", "bar", "baz");

	var result = MoreEnumerable.Sequence(5, 8).ZipMap(i => i % 2 == 0);
	using var xs = TestingSequence.Of(5, 6, 7, 8);
	var result = xs.ZipMap(i => i % 2 == 0);

		/// Applies a function on each element and returns a sequence of
		/// tuples with the source element and the result from the function.

-        /// Applies a function on each element and returns a sequence of
-        /// tuples with the source element and the result from the function.
+        /// Applies a function on each element of the sequence and returns a
+        /// sequence of tuples with the source element and the result from the
+        /// function.

	a function applied on each element.
	a function applied to each element.

Add ZipMap #763

Are you sure you want to change the base?

Add ZipMap #763

Conversation

matachi commented Oct 1, 2020

viceroypenguin commented Jul 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atifaziz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment