Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interruptsource): support ssr with the default interrupt sources #159

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

un1c0rnr1d3r
Copy link
Collaborator

enable lazy initialization of the event target and skip the initialization when rendering on a
server platform to avoid unsafe references to window or document

fix #77, #115

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Library does not support SSR applications.

What is the new behavior?
Adds SSR support when using the default interrupt sources and enables custom interrupt sources to potentially support SSR.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Other information:
This PR was inspired by the previous PR for SSR support #130. It builds on the previous PR and addresses the problem of creating the default interrupt sources array while rendering on the server without referencing unavailable objects such as document and window.

enable lazy initialization of the event target and skip the initialization when rendering on a
server platform to avoid unsafe references to window or document

fix grbsk#77, grbsk#115
@coveralls
Copy link

coveralls commented Sep 29, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling c96f243 on worksoncloud:ssr-platform into e2af040 on moribvndvs:master.

Copy link
Owner

@grbsk grbsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants