Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-master branches in index unsupported by cargo #16

Closed
yodaldevoid opened this issue Mar 1, 2021 · 3 comments
Closed

non-master branches in index unsupported by cargo #16

yodaldevoid opened this issue Mar 1, 2021 · 3 comments

Comments

@yodaldevoid
Copy link
Contributor

cargo at the moment does not support indexes with a main branch as anything other than master. See rust-lang/cargo#4024 for the PR that forced this and rust-lang/cargo#7329 for an issue tracking support for other branches.

ktra's default branch is currently main and it makes it seem like main will work as a main branch for an index in it's documentation. Until cargo adds support, I think ktra should change it's default branch and all references in the documentation to master to avoid difficulty when a user is trying to set up a new registry.

@vojtechkral
Copy link

This has been fixed in cargo, these days it handles the main branch just fine.
This issue can be closed...

@gagbo
Copy link
Collaborator

gagbo commented Apr 20, 2022

Hello,

In any case, the branch name used in the registry is now a configuration option. So if there is still the cargo issue (I didn't test sorry), we'll make a change to moriturus/ktra-book to mark it in the documentation

@gagbo gagbo closed this as completed Apr 20, 2022
@vojtechkral
Copy link

I tested with main and it simply works, cargo has no complaints :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants