Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap images to expand them #31

Open
buresdv opened this issue Jun 9, 2023 · 5 comments
Open

Tap images to expand them #31

buresdv opened this issue Jun 9, 2023 · 5 comments
Assignees
Labels
CURRENT CYCLE enhancement New feature or request "Like Apollo" Feature Requests that derive from Apollo TOP PRIORITY
Milestone

Comments

@buresdv
Copy link
Contributor

buresdv commented Jun 9, 2023

Introduction

As it is now, there is no way to tap on a picture and have it enter full screen.

Requirements

Add the possibility to tap on a picture to make it fullscreen. It should behave like in Photos, where tapping a picture expands it and then you can move it around and flick it away.

Should look like this: https://streamable.com/8xz0hv. Lemmy doesn't support albums, so there's no need to support more than one picture in a post.

What I Need

Rework the relevant files containing image views ( Post Item ) to support this feature. Also implement mlemgroup/mormaer-mlem#61 to comply with Apple's guidelines around NSFW material.

@BrooklynMan
Copy link
Contributor

also, when expanded, a long-press should offer options to save the image to photos, share, etc. the standard options.

AlphaPro06 referenced this issue in AlphaPro06/Mlem Jun 10, 2023
@ShadowJonathan ShadowJonathan added the "Like Apollo" Feature Requests that derive from Apollo label Jun 11, 2023
@porkins
Copy link

porkins commented Jun 13, 2023

Similarly. If you tap a picture in a comment, such as the lemmy.world stickied starting guide, the behavior is a bit unexpected as it will just roll up the post. I wanted to tap the very large infographic to get into it, so I could zoom to see the small text.

AlphaPro06 referenced this issue in AlphaPro06/Mlem Jun 15, 2023
@ShadowJonathan ShadowJonathan transferred this issue from mlemgroup/mormaer-mlem Jul 3, 2023
@ShadowJonathan ShadowJonathan added this to the 1.1 milestone Jul 3, 2023
@ShadowJonathan ShadowJonathan moved this from To Triage to Todo in Development Tracker Jul 3, 2023
@EricBAndrews EricBAndrews moved this from Todo to On Hold in Development Tracker Jul 3, 2023
@EricBAndrews EricBAndrews modified the milestones: v1.1, v1.0 Jul 7, 2023
@EricBAndrews EricBAndrews moved this from Holding Pattern to Under Development in Development Tracker Jul 7, 2023
@EricBAndrews EricBAndrews modified the milestones: v1.0, ASAP Jul 7, 2023
@EricBAndrews EricBAndrews modified the milestones: ASAP, v1.1 Jul 13, 2023
@rubythulhu
Copy link

The only thing that makes mlem a sub-par lemmy app to me is that I can't save images, and have to do an awkward click "..." button -> share -> copy url -> paste into safari -> hope that doesn't fail -> save image via safari.

I just want to save memes :(

@tht7
Copy link
Contributor

tht7 commented Jul 14, 2023

Working on it man!

#171

@EricBAndrews
Copy link
Member

Moving this to "future"--we want to have a nice full-screen image viewer rather than the sheet, but that's a hefty chunk of development and should wait until post-2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CURRENT CYCLE enhancement New feature or request "Like Apollo" Feature Requests that derive from Apollo TOP PRIORITY
Projects
Status: Under Development
Development

No branches or pull requests

7 participants