Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focusFirstSuggestion only focuses the first suggestion if the suggestions list changes #225

Closed
r-f-j-thomas opened this issue Aug 24, 2016 · 5 comments
Labels

Comments

@r-f-j-thomas
Copy link

When focusFirstSuggestion is set, it appears that the first suggestion is only focused when the suggestion list changes. If additional typing does not refine the suggestions list (most commonly when there is only one suggestion left), then the focus is removed.

For example on this Codepen, if you type 'j' then 'Java' is focused. If you type 'ja' then both 'Java' and 'Javascript' are displayed, but neither are focused.

@moroshko
Copy link
Owner

Thanks for reporting, this is clearly a bug. I'll have a look.

@moroshko
Copy link
Owner

This is fixed in v5.1.2 now

@r-f-j-thomas
Copy link
Author

Thank you for looking at this so quickly!

I believe it may have had an unintended side effect though. Now when focusFirstSuggestion is enabled, mouse hover does not change the highlighted item. The focus on the first suggestion seems to be overriding the mouse hover.

When there is a scrollbar, the mouse hover is also jumping the scroll point back to the top of the list.

@moroshko
Copy link
Owner

You're right, let me check.

@moroshko moroshko reopened this Aug 26, 2016
@esseb esseb mentioned this issue Aug 26, 2016
@moroshko
Copy link
Owner

This is fixed in v6.0.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants