[doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()

morozov · May 14, 2021 · bd18ec4 · bd18ec4
1 parent b728198
commit bd18ec4
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 3 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
@@ -1610,7 +1610,7 @@ protected function getReservedKeywordsClass()
      */
     public function quoteSingleIdentifier($str)
     {
-        return '[' . str_replace(']', '][', $str) . ']';
+        return '[' . str_replace(']', ']]', $str) . ']';
     }
 
     /**

diff --git a/tests/Doctrine/Tests/DBAL/Functional/Platform/QuotingTest.php b/tests/Doctrine/Tests/DBAL/Functional/Platform/QuotingTest.php
@@ -2,8 +2,11 @@
 
 namespace Doctrine\Tests\DBAL\Functional\Platform;
 
+use Doctrine\DBAL\Platforms\OraclePlatform;
 use Doctrine\Tests\DbalFunctionalTestCase;
 
+use function key;
+
 class QuotingTest extends DbalFunctionalTestCase
 {
     /**
@@ -29,4 +32,41 @@ public static function stringLiteralProvider(): iterable
             'single-quote' => ["'"],
         ];
     }
+
+    /**
+     * @dataProvider identifierProvider
+     */
+    public function testQuoteIdentifier(string $identifier): void
+    {
+        $platform = $this->connection->getDatabasePlatform();
+
+        /**
+         * @link https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements008.htm
+         */
+        if ($platform instanceof OraclePlatform && $identifier === '"') {
+            self::markTestSkipped('Oracle does not support double quotes in identifiers');
+        }
+
+        $query = $platform->getDummySelectSQL(
+            'NULL AS ' . $platform->quoteIdentifier($identifier)
+        );
+
+        $row = $this->connection->fetchAssociative($query);
+
+        self::assertNotFalse($row);
+        self::assertSame($identifier, key($row));
+    }
+
+    /**
+     * @return iterable<string,array{0:string}>
+     */
+    public static function identifierProvider(): iterable
+    {
+        return [
+            '[' => ['['],
+            ']' => [']'],
+            '"' => ['"'],
+            '`' => ['`'],
+        ];
+    }
 }
diff --git a/tests/Doctrine/Tests/DBAL/Platforms/AbstractSQLServerPlatformTestCase.php b/tests/Doctrine/Tests/DBAL/Platforms/AbstractSQLServerPlatformTestCase.php
@@ -545,14 +545,14 @@ public function testModifyLimitSubquerySimple(): void
 
     public function testQuoteIdentifier(): void
     {
-        self::assertEquals('[fo][o]', $this->platform->quoteIdentifier('fo]o'));
+        self::assertEquals('[fo]]o]', $this->platform->quoteIdentifier('fo]o'));
         self::assertEquals('[test]', $this->platform->quoteIdentifier('test'));
         self::assertEquals('[test].[test]', $this->platform->quoteIdentifier('test.test'));
     }
 
     public function testQuoteSingleIdentifier(): void
     {
-        self::assertEquals('[fo][o]', $this->platform->quoteSingleIdentifier('fo]o'));
+        self::assertEquals('[fo]]o]', $this->platform->quoteSingleIdentifier('fo]o'));
         self::assertEquals('[test]', $this->platform->quoteSingleIdentifier('test'));
         self::assertEquals('[test.test]', $this->platform->quoteSingleIdentifier('test.test'));
     }