Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLServer platform quoteIdentifier wrong escaping #4643

Closed
zajca opened this issue May 11, 2021 · 2 comments · Fixed by #4648
Closed

SQLServer platform quoteIdentifier wrong escaping #4643

zajca opened this issue May 11, 2021 · 2 comments · Fixed by #4648
Labels
Bug Quoting SQL Server
Milestone
2.13.2

Comments

@zajca
Copy link

zajca commented May 11, 2021 •
edited

Bug Report

Q A
BC Break no
Version all

Summary

It looks like that escaping identifier for sql platform is broken since day one.

Current behaviour

This is in tests:

dbal/tests/Platforms/AbstractSQLServerPlatformTestCase.php

Line 576 in 6611e6d

self::assertEquals('[fo][o]', $this->platform->quoteSingleIdentifier('fo]o'));

But if I try for example create table

CREATE TABLE [test_escaping].[fo][o] ([col1] INT);
-- Failed to execute query. Error: Parse error at line: 1, column: 34: Incorrect syntax near '[o]'.

Expected behaviour

Expected output should be [fo]]o]

CREATE TABLE [test_escaping].[fo]]o] ([col1] INT);
-- Query succeeded: Affected rows: 0

So the function should be:

    public function quoteSingleIdentifier($str)
    {
        return '[' . str_replace(']', ']]', $str) . ']';
    }

Output is than same as from

SELECT QUOTENAME('fo]o');
-- [fo]]o]

https://docs.microsoft.com/en-us/sql/t-sql/functions/quotename-transact-sql?view=sql-server-ver15
@zajca zajca mentioned this issue May 11, 2021
Merged
@morozov morozov mentioned this issue May 13, 2021
Merged
@morozov morozov linked a pull request May 13, 2021 that will close this issue
[GH-4643] Fix SQLServerPlatform::quoteIdentifier() #4648
Merged
@morozov morozov added this to the 2.13.2 milestone May 13, 2021
morozov added a commit to morozov/dbal that referenced this issue May 13, 2021
@morozov
[doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
ecf3706
morozov added a commit to morozov/dbal that referenced this issue May 14, 2021
@morozov
[doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
0eabc72
morozov added a commit to morozov/dbal that referenced this issue May 14, 2021
@morozov
[doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
bd18ec4
morozov added a commit that referenced this issue May 14, 2021
@morozov
Merge pull request #4648 from morozov/issues/4643
69ad868 
[GH-4643] Fix SQLServerPlatform::quoteIdentifier()
@morozov
Copy link
Member

morozov commented May 15, 2021

Closed via #4648.

@morozov morozov closed this as completed May 15, 2021
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
ec52079 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
e17571f 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
63da56a 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 5, 2021
@derrabus
Merge branch '2.13.x'
0db9cd9 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 6, 2021
@derrabus
Merge branch '2.13.x'
b02c367 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params
derrabus added a commit to derrabus/dbal that referenced this issue Jun 7, 2021
@derrabus
Merge branch '2.13.x' into merge/2.13.x
4fdc8f9 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params

Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus added a commit to derrabus/dbal that referenced this issue Jun 7, 2021
@derrabus
Merge branch '2.13.x'
e6add29 
* 2.13.x:
  Bump doctrine/coding-standard
  [doctrineGH-4643] Fix SQLServerPlatform::quoteIdentifier()
  [doctrineGH-4645] Use error suppression instead of an error handler in MySQLi Connection
  Rewrote `DriverManagerTest` replica/shards test scenarios to verify whole data structure equality
  Add type-inference tests to github actions, so that we test also that types match up
  Add warnings in docblocks
  Rework the caching documentation
  Fix doctrine#4637 by duplicating the type definition for `DriverManager::getConnection($args)` params

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Quoting SQL Server
Projects
None yet
Milestone
2.13.2
Development

Successfully merging a pull request may close this issue.

[GH-4643] Fix SQLServerPlatform::quoteIdentifier() morozov/dbal
2 participants
@morozov @zajca