Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: split_header doesn't remove 'OAuth ' string at the start of a header #20

Closed
GoogleCodeExporter opened this issue Apr 4, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

OAuthRequest::split_header() receiver header as it came over http. 
Spec says that header should look like this:

Authorization: OAuth realm="http://sp.example.com/",
oauth_consumer_key="0685bd9184jfhq22",
....

Note the 'OAuth' part which specifies authorization type.
OAuthRequest::split_header() doesn't strip it before
parsing, and also throws away everything not starting 
with 'oauth_', thus first parameter is always lost, 
whether it is unused (?) realm or any other oauth parameter.

Attached patch fixes this behaviour simply.

Original issue reported on code.google.com by atregoub...@gmail.com on 31 Mar 2008 at 2:54

Attachments:

@GoogleCodeExporter
Copy link
Author

looking in to this to verify intended behavior 

Original comment by andyster on 15 Jul 2008 at 10:39

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by andyster on 15 Jul 2008 at 10:59

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant