Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing setup #14

Closed
MathisGD opened this issue Oct 5, 2023 · 0 comments · Fixed by #89
Closed

Refactor testing setup #14

MathisGD opened this issue Oct 5, 2023 · 0 comments · Fixed by #89
Assignees
@Rubilmax

Comments

@MathisGD
Copy link
Contributor

MathisGD commented Oct 5, 2023

I don't like this because nothing ensures the RPC URL points to mainnet, whereas the setup in morpho-blue-bundlers does
But it's something for later, non-blocking

Originally posted by @Rubilmax in #1 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enforce chain id is 1 in tests morpho-org/morpho-blue-oracles
2 participants
@Rubilmax @MathisGD