Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use optimized WadRayMath #71

Closed
Rubilmax opened this issue Jul 6, 2023 · 6 comments · Fixed by #109
Closed

Use optimized WadRayMath #71

Rubilmax opened this issue Jul 6, 2023 · 6 comments · Fixed by #109
Assignees
@Rubilmax

Comments

@Rubilmax
Copy link
Collaborator

Rubilmax commented Jul 6, 2023

Instead of https://github.com/morpho-labs/blue/blob/dev/src/libraries/MathLib.sol
@MathisGD
Copy link
Contributor

MathisGD commented Jul 6, 2023

Funny thing: I tried it already (at the beginning of development) and it was not improving with the current tests (forge snapshot --diff). Probably wrong but I don't know where

@MathisGD
Copy link
Contributor

MathisGD commented Jul 6, 2023 •
edited
Loading

For the one handling this one, I would batch it with this one #18 and #72

@MerlinEgalite
Copy link
Contributor

Do you also imply to put shares in RAY @Rubilmax ?

@Rubilmax
Copy link
Collaborator Author

Rubilmax commented Jul 7, 2023

Do you also imply to put shares in RAY @Rubilmax ?

No! Only to use what we've been building previously (and also because I prefer the wad naming lol). I don't think using ray-scale has many benefits when using shares. And it adds bytecode.

@MerlinEgalite
Copy link
Contributor

Seems ok to me!

@MerlinEgalite
Copy link
Contributor

@Rubilmax I guess you can do it?

@MerlinEgalite MerlinEgalite mentioned this issue Jul 9, 2023
Closed
This was referenced Jul 10, 2023
Closed
Closed
@Rubilmax Rubilmax linked a pull request Jul 11, 2023 that will close this issue
Refactor: use morpho utils #90
Closed
@Rubilmax Rubilmax mentioned this issue Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Rubilmax @MerlinEgalite @MathisGD