Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11Y focus indicator changes #192

Open
cehfisher opened this issue Aug 11, 2017 · 0 comments
Open

A11Y focus indicator changes #192

cehfisher opened this issue Aug 11, 2017 · 0 comments
Assignees
Labels

Comments

@cehfisher
Copy link

cehfisher commented Aug 11, 2017

The issue is:

Thanks for adding back the focus indicators to the theme! It's good to have them in place, but there are ways to make them even better. :)

Some focus indicators are odd and that can be confusing to users. For example, how do you know what this will trigger?
focus

Where (url)

Ex. http://drupalvm-eleven.dev/admin/structure/contact

How to Fix:

Put the focus indicator on the element itself, rather than a parent/wrapper element. In this particular example, put the focus on the button element instead of the .contextual-region element.

OK way to indicate focus:
wrong-focus

Better way to indicate focus:
right-focus

Just updating this part will take you a long way. Some additional ways to make this rock:

  1. Keep the focus indicator color consistent (not switching from blue to pink).
  2. Make sure there is enough padding on the element being focused on, so the indicator can be fully seen.
    padding
  3. Change the color to something that passes WCAG 2.0 color contrast standards. Ex. Change the outline color from bluesky (#18a9e0) to something darker like #007EAE or reset the focus indicator to use the default browser styling.

(cc @widescreenBob)

@mortendk mortendk added this to the 8.0 Beta 3 milestone Aug 11, 2017
@mortendk mortendk added the a11y label Aug 11, 2017
@mortendk mortendk self-assigned this Aug 11, 2017
@mortendk mortendk modified the milestones: 8.0 Beta 3, 8.0 Beta 4 Aug 15, 2017
@mortendk mortendk modified the milestones: 8.0 Beta 6, 8.0 Beta 4 Aug 25, 2017
@mortendk mortendk removed this from the 8.0 Beta 6 milestone Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants