Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

ascolatori won't run if optionalDependencies are not installed #189

Open
mkj28 opened this issue Jun 6, 2018 · 1 comment
Open

ascolatori won't run if optionalDependencies are not installed #189

mkj28 opened this issue Jun 6, 2018 · 1 comment

Comments

@mkj28
Copy link

mkj28 commented Jun 6, 2018

yarn install --ignore-optional let's you install ascolatori without pulling in eventemitter2, but then it throws:

Error: Cannot find module 'eventemitter2'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/edge-broker/node_modules/ascoltatori/lib/event_emitter2_ascoltatore.js:7:21)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/edge-broker/node_modules/ascoltatori/lib/ascoltatori.js:13:43)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/edge-broker/node_modules/ascoltatori/index.js:2:18)

@mvayngrib
Copy link

mvayngrib commented Jun 21, 2018

maybe the exports that pull in various optional libs can be lazy-evaluated, via defineProperty, and a getter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants